usgo / agagd

American Go Association Games Database (AGAGD)
https://agagd.usgo.org
MIT License
47 stars 30 forks source link

Improve search based on player name #248

Closed abaisero closed 2 years ago

abaisero commented 2 years ago

Is your feature request related to a problem?

The current player name search seems to be based on a very naive substring matching, which causes a number of very simple and straightforward search queries to fail.

I'll use the top ranked player's name (Albert Yen) as an example, also because it showcases additional issues which arise when someone has very common first and last names:

Especially when someone has very common name or surname, it seems like the only way to find their profile quickly is to match the exact format "surname, name" with the correct number of spaces and commas located at the right places. Further, the search query needs to be at least sanitized to remove unnecessary spaces or commas from the query.

Describe the feature you'd like to see on the AGAGD.

I don't know much about best practices when it comes to finding fuzzy substring matches, but off the top of my head the following would be a simple improvement which would address the biggest of the above issues:

abaisero commented 2 years ago

Just realized this is related to #164, might warrant closing this.

abaisero commented 2 years ago

fixed by #249