Confirm email addresses

usgo / gocongress

Annual US Go Congress Website

https://www.gocongress.org

MIT License

20 stars 17 forks source link

Confirm email addresses #207

Closed jaredbeck closed 3 years ago

jaredbeck commented 3 years ago

Closes #184

I've done some very limited testing in local dev. I'd recommend further manual testing of the following:

sign up -> confirm -> sign in
sign in without confirming, should get message like "sorry, you're inactive"
change email -> confirm -> sign in with new email
change email -> don't confirm -> sign in with old email
change email -> receive warning that it changed delivered to old address
change password

The default wording is used for the various emails and flash messages. This wording can be customized in future PRs.

neagle commented 3 years ago

Very excited to check this out--thanks again for taking this task on!

Checked out the branch
Ran bundle install
Ran rake db:migrate
Ran rails server
Navigated to localhost:3000
Got this error:

If I add the year to the URL, the page seems to load correctly... and now, mysteries of mysteries, when I go back to the root (localhost:3000), it seems to be working. 😓

I also got an error when trying to sign up, possibly related to my local settings:

...I have GMAIL_SMTP_USER and GMAIL_SMTP_PASSWORD values in my .env file that I grabbed from Heroku; any advice on how the SMTP stuff should work locally?

Anyway -- sorry for the initial bumps, hopefully we can smooth 'em out.

neagle commented 3 years ago

Just tested out your branch and things worked great. One thought I had... when I signed up and checked my email, I immediately had two messages waiting for me:

The confirmation email, and the welcome email. I think that, ideally, we'd like to shift the confirmation email to only go out when the account is actually confirmed, rather than when it's created. That way a user isn't confused about which email to look into for the account confirmation step. What do you think?

jaredbeck commented 3 years ago

I think that, ideally, we'd like to shift the confirmation email to only go out when the account is actually confirmed, rather than when it's created.

Good catch. Done in b0494a660ec1d2badf6c80af1f8706500f3a60c9. Not tested in browser yet.

neagle commented 3 years ago

Closes #184. Thanks a lot for this feature, @jaredbeck!