search

usgo / gocongress

Annual US Go Congress Website
https://www.gocongress.org
MIT License
20 stars 17 forks source link

User Must Have a Confirmed Email #230

Closed michaelhiiva closed 3 years ago

michaelhiiva commented 3 years ago

Summary of the Bug

If the user created in the instructions does not have a confirmed email, one cannot Sign In.

Steps to Reproduce the Behaviour

  1. Follow the steps for creating a user in GoCongress instructions.
  2. Attempt to Sign In on http://localhost:3000/2021/sign_ups/sign_in

The Expected Behaviour

One should be able to Sign In to the 2021 year without verification for development.

Screenshots

Screenshot from 2021-06-19 14-17-28

michaelhiiva commented 3 years ago

When testing a second time, this issue seems resolved. Cannot reproduce.

neagle commented 3 years ago

Yeah, there must have been something going on with exactly when you created your user -- this line in the user account creation script makes sure that the new account is already treated as confirmed: https://github.com/usgo/gocongress/pull/229/files#diff-b6358c5d68b103b660c64877e5e333b07ae4221ddf5a8ebced0b9eb0da523902R8