usgs-coupled / phreeqcrm

https://usgs-coupled.github.io/phreeqcrm/
Creative Commons Zero v1.0 Universal
9 stars 7 forks source link

Expanded documentation in BMI Python example notebook #175

Closed aufdenkampe closed 4 weeks ago

aufdenkampe commented 4 weeks ago

This PR adds documentation to your extremely helpful swig/python/ex11-advect/ex11-advect.ipynb example notebook with new markdown, comments, and additional outputs. @shannarucker and I were careful to limit our edits to work with your lean conda environment.yml by not adding any extra dependencies and to follow your original workflow. The entire notebook runs in a couple of seconds.

These edits helped our team learn and share the impressive capabilities of PhreeqcRM, BMIPhreeqcRM, YAMLPhreeqcRM for automating and coupling Phreeqc to external advection models. We imagine that our expanded documentation could help others too.

@scharlton2 & @dlparkhurst, thanks for your efforts over the last year to developing a BMI Python wrapper for PHREEQC! Our team expects to leverage these capabilities substantially in the near future on a variety of projects.

scharlton2 commented 4 weeks ago

Thanks @aufdenkampe and @shannarucker