Open mhines-usgs opened 4 years ago
I just want to reiterate that the Vue Application of the WBEEP project is completely decoupled from the data generation and resulting tiles. Again, we are hitting this problem of having intermingling of project concerns because they just happen to be stored in the same bucket.
If the desire is to have the ability to view other sets of tiles from the 'test' (or other) tier (without rebuilding the application, as is currently possible) this can be done by adding a source toggle switch to, I would suggest, the 'qa' version of the application, that will allow users to switch the tile source on the fly. I am guessing that it would also be possible to swap in and out map style sheets in a similar manner.
I think we should either create a new tier for the pipeline, or else be able to toggle an existing tier between them. We don't want to permanently switch an existing tier to the dev model pipeline, since that would potentially introduce additional variables to our existing setup, besides changes to our code base.
This is resurfacing because they are working on switching the pipeline to using the new geospatial fabric version and we will need to get our tiles built using the new geospatial fabric (see this SB object) before moving things out to prod. I believe @wdwatkins has had recent experience with the new GF version.
My suggestion is to create a new viz tier called dev-model
or something to do this kind of work on. I wouldn't mind a quick conversation early next week once David is back on this topic (perhaps we can stay on the standup line for an extra few minutes Monday).
I have only used the flowlines, not the actual HRUs, but seeing the difference between the flowlines versions I don't think many changes to our codebase should be required, to use the new version, hopefully just changing the field names
The only things that ring in my ears, are that we eliminated some HRUs because they didn't have data in the tile-join process, not sure if we will need to revisit that. here is the line that does the exclusion: https://github.com/usgs-makerspace/wbeep-processing/blob/master/jenkins/tippecanoe_tile_join_Jenkinsfile#L48
Yeah, even if those were due to lack of input data rather than the fabric, maybe the HRU ids will have changed?
Tried to grab the GF*. file to compare and it doesn't appear to work anymore, i end up with an error page
That's normally not the error you get if it is private though
Can you try again @mhines-usgs? I am not logged in and can see it:
https://www.sciencebase.gov/catalog/item/5e29d1a0e4b0a79317cf7f63
Yeah, I could see that item just fine, it was the 932mb zip file I was trying to download below that was triggering that error. Just now it seems to be working, though!
Oh gotcha. I wondering if they were updating or something? Glad it is working now.
I think what we'll be doing is replacing the geodatabase that we start our tile generation pipeline with, and then provide a completely separate tier set up where they can look at their dataset on the other end. In order to support that, I think we need to...
for wbeep processing:
for wbeep viz:
Update on this issue: I spoke with Jen Rapp about this and we decided it is a nice-to-have for this FY. It is still important to deliver, but does not need to be constrained by the FY end.
Let's review this issue and determine if it should be on the current task list or if the one I started works instead.
Steve Markstrom wants to iterate on the data coming out of their model.
Ivan cut a release of the current model and this is what is currently powering all of our tile generation.
He is now making a copy of this process that will be used by Steve Markstrom et al to iterate on the data.
[ ] Decide where to put the tiles and where to display the tiles that are coming out of this dev/test data processing tier
[ ] set up needed jenkins jobs to process those new data and create s3 space to display it
[ ] add the 'experimental' model output as a source to the map. This should probably be done in the code and not the style sheet so that we can conditionally exclude it based on deployment tier.
[ ] Add the 'experimental' model as a layer
[ ] Make a toggle button (like the 'zoom level indicator') so that we can toggle the experimental layer
[ ] Hide the real 'HRU' layers when the experimental layers are on
Lindsay suggested we may also want to consider setting up a different tier to display this, or perhaps we use QA?