usgs-makerspace / makerspace-sandbox

Some initial R code for playing with data processing (maybe some light visualization).
Other
0 stars 5 forks source link

Water use bar chart updates to make Winter Irrigation visible #652

Closed jenniferRapp closed 3 years ago

jenniferRapp commented 3 years ago
lindsayplatt commented 3 years ago

The log scale really dramatically changes the pattern IMO

image

image

jenniferRapp commented 3 years ago

https://onlinelibrary.wiley.com/cms/asset/1de3b634-5eb7-456b-b0ae-05a5b48a7ef0/jawr12877-fig-0002-m.jpg In the X axis here the spacing for low volumes are almost equally represented as the space between 1000 and 10,000. So it emphasizes those small values nicely. I suppose since we have such a wide range up to 400,000 that it is not going to make much of a difference. Seems like we should focus on highlighting the space when someone hovers over each season and thickening the winter line if possible.

lindsayplatt commented 3 years ago

Hmmm I guess the idea here is that we want to emphasize that those are much smaller in comparison to the big values (at least that is my understanding).

The hovers over each season are on test if you want to see that! I will work on getting the line to show up a little better.

jenniferRapp commented 3 years ago

That looks great. Can you make all winter highlight regardless of where the person clicks or Hovers? JEn

From: Lindsay (Carr) Platt notifications@github.com Sent: Tuesday, October 6, 2020 1:40 PM To: usgs-makerspace/makerspace-sandbox makerspace-sandbox@noreply.github.com Cc: Rapp, Jennifer L jrapp@usgs.gov; Author author@noreply.github.com Subject: [EXTERNAL] Re: [usgs-makerspace/makerspace-sandbox] Water use bar chart updates to make Winter Irrigation visible (#652)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

Hmmm I guess the idea here is that we want to emphasize that those are much smaller in comparison to the big values (at least that is my understanding).

The hovers over each season are on test if you want to see that! I will work on getting the line to show up a little better.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/usgs-makerspace/makerspace-sandbox/issues/652#issuecomment-704437364, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBB4BPSGBZQWV25N65IXSDSJNI55ANCNFSM4SEUOZ3Q.

lindsayplatt commented 3 years ago

I know what I need to do now to get the irrigation data to be seen (now I just need to do it). It is currently being hidden by the axis because the line has a stroke-width of 5. I can shift the line up or down based on the known stroke-width we want so that it doesn't cover up our data.

Example: data is black. current implementation is red, shift up half of width is blue, shift down half of width is green

image

<?xml version="1.0" encoding="UTF-8"?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 1000 625" preserveAspectRatio="xMidYMid meet" version="1.1">
  <path d="M45 100h310 v-50 h-310Z"/>
  <path d="M50 100h100" stroke="red" stroke-width="5"/>
  <path d="M150 97.5h100" stroke="blue" stroke-width="5"/>
  <path d="M250 102.5h100" stroke="green" stroke-width="5"/>
</svg>
mwernimont commented 3 years ago

@jenniferRapp RE: Can you make all winter highlight regardless of where the person clicks or Hovers?

As in when you hover over 1 winter both are highlighted?

jenniferRapp commented 3 years ago

that is correct.

lindsayplatt commented 3 years ago

Changing color & line width of the axis helps to show that data exists in Winter a little bit better, but it still isn't great

image

jenniferRapp commented 3 years ago

Seems a bit better. Can you make the axis colors match? Y &X.

lindsayplatt commented 3 years ago

Hmmm they do match ...

lindsayplatt commented 3 years ago

maybe because the winter is highlighted, it is making it look like the y-axis is darker?

mwernimont commented 3 years ago

@jenniferRapp Double winter highlighting is on test

jenniferRapp commented 3 years ago

Nice. Thank you.

From: Marty Wernimont notifications@github.com Sent: Wednesday, October 7, 2020 3:42 PM To: usgs-makerspace/makerspace-sandbox makerspace-sandbox@noreply.github.com Cc: Rapp, Jennifer L jrapp@usgs.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [usgs-makerspace/makerspace-sandbox] Water use bar chart updates to make Winter Irrigation visible (#652)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@jenniferRapphttps://github.com/jenniferRapp Double winter highlighting is on test

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/usgs-makerspace/makerspace-sandbox/issues/652#issuecomment-705153383, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBB4BOFPHVKOGKHKFOV2RLSJTABXANCNFSM4SEUOZ3Q.

jenniferRapp commented 3 years ago

I was looking at git hub image on my phone. I see that the axis color are the same now.

From: Lindsay (Carr) Platt notifications@github.com Sent: Wednesday, October 7, 2020 1:28 PM To: usgs-makerspace/makerspace-sandbox makerspace-sandbox@noreply.github.com Cc: Rapp, Jennifer L jrapp@usgs.gov; Mention mention@noreply.github.com Subject: [EXTERNAL] Re: [usgs-makerspace/makerspace-sandbox] Water use bar chart updates to make Winter Irrigation visible (#652)

This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

maybe because the winter is highlighted, it is making it look like the y-axis is darker?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/usgs-makerspace/makerspace-sandbox/issues/652#issuecomment-705084015, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBB4BJJ4KD5XAIO2KSMXKDSJSQK7ANCNFSM4SEUOZ3Q.

lindsayplatt commented 3 years ago

@mwernimont I had PR'd my code changes, but the additional changes to get the bottom of the bars to be seen need to be done using CSS.

https://github.com/usgs-makerspace/makerspace-sandbox/issues/652#issuecomment-705005165