usgs-makerspace / makerspace-sandbox

Some initial R code for playing with data processing (maybe some light visualization).
Other
0 stars 5 forks source link

add a disclaimer banner over the mappers #666

Closed jenniferRapp closed 4 years ago

jenniferRapp commented 4 years ago

Similar to Jordan's new viz can we add a banner before the mappers go out for review?

https://labs-beta.waterdata.usgs.gov/visualizations/fire-hydro/index.html#/

mwernimont commented 4 years ago

@jenniferRapp Are we also talking the storage mapper? Thats already released, so don't think it needs the banner, but maybe it can be added if needed.

jenniferRapp commented 4 years ago

No. Not the storage mapper. Thanks for checking.

Jennifer Rapp Sent from my mobile device 804-615-6868

On Oct 8, 2020, at 9:30 AM, Marty Wernimont notifications@github.com wrote:



This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.

@jenniferRapphttps://github.com/jenniferRapp Are we also talking the storage mapper? Thats already released, so don't think it needs the banner, but maybe it can be added if needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/usgs-makerspace/makerspace-sandbox/issues/666#issuecomment-705568608, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIBB4BJGG34IROVDTA5VDXDSJW5CFANCNFSM4SIX2Y6Q.

mwernimont commented 4 years ago

PR created: https://github.com/usgs-makerspace/wbeep-viz/pull/534

mwernimont commented 4 years ago

Merged and on test. Some weird legend stuff going on test currently, but will be cleaned up in my next PR for another ticket.

jenniferRapp commented 4 years ago

You did what I asked. I tend to think that it's a bit extreme to say "Do not use for ANY purpose". Then why bother creating this map? Can we update as edited below?

ATTENTION! - You are viewing a prototype application that is in active development. Contents seen here are preliminary visualizations of model output. DO NOT CITE or use information contained in this application until review and final application is released.

mwernimont commented 4 years ago

Merged and being pushed to test Screen Shot 2020-10-09 at 8 59 42 AM

mwernimont commented 4 years ago

on Test

jenniferRapp commented 4 years ago

Looks great