usgs-makerspace / makerspace-sandbox

Some initial R code for playing with data processing (maybe some light visualization).
Other
0 stars 5 forks source link

water temp/water storage: verify there isn't a bug in the layer list function #682

Closed mhines-usgs closed 3 years ago

mhines-usgs commented 3 years ago

verify that the layer list is correctly showing what layers are on and off. someone suggested that " when you select a layer not visible beyond a certain scale (e.g., roads) and zoom out, the layer turns off when you zoom out, then turns back on when you zoom in. However, the layer is no longer highlighted in the layer list as being turned on when you zoom back in although it is visible in the map."

this was specifically commented on the water storage page but I would assume it would impact water temp too.

mhines-usgs commented 3 years ago

i can see it behaving oddly but I haven't been able to figure out how to fix it yet.

here's how to describe it.. when you first load the water storage map, open the layer list. you'll see all the layers gray/unavailable with the exception of terrain which is blue/on.

leave the layer list open, and zoom in until other layers are white/available. the problem is that roads doesn't correct its state to blue/on when it hits the proper zoom. roads must get in a weird state with the initial load. because technically it's on but unavailable, versus off and unavailable. once it gets to be available, it never triggers blue/on like it should.

if you turn it on and off, it starts to work correctly, unless you trigger that it will lose the blue/on status when it goes gray/unavailable during zoom out, and then if you zoom in again, the same problem occurs. it never turns blue.

mhines-usgs commented 3 years ago

@mwernimont not sure how slammed you are, but i'm wondering if you could take this on if it's possible to fix. i am not sure if we ever noticed this before or if it was known as an issue we couldn't figure out.

mwernimont commented 3 years ago

@mhines-usgs I can look into it.

mwernimont commented 3 years ago

PR: https://github.com/usgs-makerspace/wbeep-viz/pull/587