Closed emartinez-usgs closed 8 years ago
.classname > tagname
selectors. Prefer to add a class to the child tag name and target that directly.
/* Less good */
.parent {
> .child {
}
}
/* Preferred */
.parent {
}
.parent-child {
}
Default module should be an actual OriginModule
and not a stub. This is better because if the module ID changes in the future, the pin will not break.
Reformat content...
There's a potential bug for review status, if the product property review-status is null then toUpperCase will generate an error: https://github.com/usgs/earthquake-eventpages/blob/master/src/htdocs/js/origin/OriginPinView.js#L50
Also, should the origin pin attributes be alphabetized? (depth, magnitude, review status, time)
I don't feel alphabetizing is necessary. A logical order is fine, especially when the list of attributes is so short.
Create product-specific pin for origin products.