usgs / earthquake-eventpages

Web application for displaying earthquake event pages.
Other
28 stars 22 forks source link

OriginPin #551

Closed emartinez-usgs closed 8 years ago

emartinez-usgs commented 8 years ago

Create product-specific pin for origin products.

emartinez-usgs commented 8 years ago
/* Less good */
.parent {
  > .child {
  }
}

/* Preferred */
.parent {
}
.parent-child {
}
jdbrown-USGS commented 8 years ago
emartinez-usgs commented 8 years ago

Default module should be an actual OriginModule and not a stub. This is better because if the module ID changes in the future, the pin will not break.

emartinez-usgs commented 8 years ago

Reformat content...

emartinez-usgs commented 8 years ago
jmfee-usgs commented 8 years ago

There's a potential bug for review status, if the product property review-status is null then toUpperCase will generate an error: https://github.com/usgs/earthquake-eventpages/blob/master/src/htdocs/js/origin/OriginPinView.js#L50

Also, should the origin pin attributes be alphabetized? (depth, magnitude, review status, time)

emartinez-usgs commented 8 years ago

I don't feel alphabetizing is necessary. A logical order is fine, especially when the list of attributes is so short.