usgs / earthquake-latest-earthquakes

Mobile friendly, interactive earthquake map and list application.
Other
11 stars 25 forks source link

Map breaks after initial pan #265

Closed emartinez-usgs closed 8 years ago

emartinez-usgs commented 8 years ago

To reproduce:

http://earthquake.usgs.gov/earthquakes/map/#%7B%22feed%22%3A%227day_m45%22%2C%22search%22%3Anull%2C%22sort%22%3A%22newest%22%2C%22basemap%22%3A%22terrain%22%2C%22autoUpdate%22%3Atrue%2C%22restrictListToMap%22%3Atrue%2C%22timeZone%22%3A%22local%22%2C%22mapposition%22%3A%5B%5B-74.59010800882323%2C-215.5078125%5D%2C%5B79.23718500609335%2C144.4921875%5D%5D%2C%22overlays%22%3A%7B%22plates%22%3Atrue%7D%2C%22viewModes%22%3A%7B%22map%22%3Atrue%2C%22list%22%3Atrue%2C%22settings%22%3Afalse%2C%22help%22%3Afalse%7D%7D

Expected result: Map should pan. Actual result: Map appears frozen.

This appears to be related to the check of the "length" property in the MapView:

  _this.isFilterEnabled = function () {
    var filter;

    filter = _this.model.get('restrictListToMap');

    if (filter.length === 0) {
      return false;
    }

    return true;
  };

And this has to do with how bookmarked settings were saved in the old version of the application vs. in the new version of the application.

This should be fixed in the new application to not break. In the interim, users can delete and re-create their bookmarks.

Note: The "Auto Update" setting is similarly affected by this parsing bug and should be fixed as well.