usgs / groundmotion-processing

Parsing and processing ground motion data
Other
54 stars 42 forks source link

Added rename project option #1013

Closed ghost closed 1 year ago

ghost commented 1 year ago
gferragu commented 1 year ago

@smithj382 have you been able to make any sense of the path errors for Windows? I was looking over the azure logs and trying to figure out what's up. It seems like a relative path issue still

ghost commented 1 year ago

@smithj382 have you been able to make any sense of the path errors for Windows? I was looking over the azure logs and trying to figure out what's up. It seems like a relative path issue still

@gferragu I tried to revert to not using relative_to for the Windows platform (as the build that passed Azure was doing), but it seems like the test used relative_to for Windows despite the if platform != "Windows": use and I'm not sure why.

emthompson-usgs commented 1 year ago

Yes, the purpose of the if-statement was to not use relative paths on Windows and it had fixed things before. I think that the reason for the errors may be unrelated to this, but it is difficult to test/debug without a Windows system to run it on.

gferragu commented 1 year ago

@smithj382 Yeah that seems weird, it's definitely still running the relative_to bit despite running on Windows

gferragu commented 1 year ago

This Python issue about relative_to looks pretty similar to what we are seeing in the Azure logs here.

emthompson-usgs commented 1 year ago

These edits were included in #1016 in which I fixed the Windows issue.