ushahidi / platform-client-mzima

Other
14 stars 99 forks source link

[USH-1238] "There are no posts yet" - Separate the text for when there are no posts & when no filters match #1460

Closed Ifycode closed 1 week ago

Ifycode commented 1 week ago

Solution implemented explained

linear[bot] commented 1 week ago

USH-1238 "There are no posts yet" - Separate the text for when there are no posts & when no filters match

Ifycode commented 1 week ago

PR now ready for review @Angamanga

Ifycode commented 1 week ago

Pasting answer here too for anyone interested:

What the change does - this.clearPostsResults(); is supposed to restore this.searchQuery to an empty string on page reload, so that the localStorage.setItem('USH_searchPostByKeyword', this.searchQuery); can be correctly set at that point. Otherwise, localstorage still has a previous value even though the search by keyword input field is cleared/empty on reload. No posts message will therefore not display the correct message we intend.

sentry-io[bot] commented 5 days ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎