Fix #476 Cannot publish to OpenStack when account has v3 as keystone version

usharesoft / hammr

Command-line tool for building consistent and repeatable machine images for multiple cloud platforms

http://hammr.io

Apache License 2.0

28 stars 24 forks source link

Fix #476 Cannot publish to OpenStack when account has v3 as keystone version #477

Closed lqueiroga closed 5 years ago

lqueiroga commented 5 years ago

Add keystone version as parameter for openstack publish builder to verify fields keystoneDomain and keystoneProject if it's v3 or tenantName if it's v2.0
Verify if account has attribute keystoneVersion to add in parameter of publish
Add new unit tests arount openstack publish builder

lqueiroga commented 5 years ago

First I hesitate a lot with this solution and finally I agree with giving cred_account to publish image builders, it's more maintainable and useful if we have the same cases for other format

segalaj commented 5 years ago

Thanks for your PR :+1: