search

usimd / pi-gen-action

Action to build Raspberry Pi images using official pi-gen tool
MIT License
44 stars 9 forks source link

Support -9e as an argument for xz compression #101

Closed dtcooper closed 8 months ago

dtcooper commented 8 months ago

Hi there,

This allows for a little more extreme compression with xz (which is what I believe Raspberry Pi uses for their distributables).

Thanks!

dtcooper commented 8 months ago

Thanks for your addition! Good idea to allow very aggressive compression, didn't even know of this setting 👍

Would you mind adding a test case to also hit the coverage?

I'm by no means a typescript expert, but I will try!

dtcooper commented 8 months ago

Was having trouble writing a test...

dtcooper commented 8 months ago

Okay! My trouble with the tests were one of the current tests wasn't working properly. It always threw an error because stageList wasn't properly converted to a list. I've fixed that test, tested for specific error cases, and added one for the new feature. Thanks!

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (014ec73) 96.16% compared to head (e831be5) 97.48%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #101 +/- ## ========================================== + Coverage 96.16% 97.48% +1.31% ========================================== Files 12 12 Lines 391 437 +46 Branches 87 109 +22 ========================================== + Hits 376 426 +50 - Misses 8 11 +3 + Partials 7 0 -7 ``` | [Flag](https://app.codecov.io/gh/usimd/pi-gen-action/pull/101/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/usimd/pi-gen-action/pull/101/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `97.48% <100.00%> (+1.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

usimd commented 8 months ago

Awesome, thanks so much for your effort!

I'll have a closer look tomorrow but I assume this should be fine and we can then merge quickly.

dtcooper commented 8 months ago

Awesome, thanks so much for your effort!

I'll have a closer look tomorrow but I assume this should be fine and we can then merge quickly.

Great! Thanks!