search

usimd / pi-gen-action

Action to build Raspberry Pi images using official pi-gen tool
MIT License
44 stars 9 forks source link

add "archive_filename" variable #53

Closed builderjer closed 1 year ago

builderjer commented 1 year ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When an image is built, pi-gen automatically adds a date to the 'image_name' variable image_name: my_image results in an image named image_2023-03-23-my_image.img

Describe the solution you'd like A clear and concise description of what you want to happen.

I would like to have another variable available in this action that is available in the pi-gen config file. the ARCHIVE_FILENAME variable shown here lets one set the final image name with what ever prefix/suffix that the user wants.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

An alternative would be to fork the RPi-Distro/pi-gen repository and maintain a fork just to get a custom image name.

Additional context Add any other context or screenshots about the feature request here.

I would fork this and do a PR, but I am not familiar with how all of these work exactly. If a change is made, I can compare the changes and learn how to fix/add and PR upstream

usimd commented 1 year ago

Thanks for reaching out and for your suggestion! I actually understand the need to customize the file name.

Before making changes in the code, I see two other options that could immediately support the case.

  1. After invoking pi-gen-action in your workflow, you could add another step to simply rename the file on disk, that shouldn't be a biggy.
  2. You could try to pass ARCHIVE_FILENAME as additional docker-opts to pi-gen-action. Similar to https://github.com/usimd/pi-gen-action/issues/43, this will set the environment variable inside the container so the build script should be able to pick it up.

Would you mind trying either one of those options before thinking about a code change?

builderjer commented 1 year ago

I will test this when I run another action on this image. Still trying to work out a few bugs on the local version. Thank you very much for such a quick response

usimd commented 1 year ago

Sure, you're welcome. Let me know how this works out.

builderjer commented 1 year ago

option 2 did not work for me. It complained about capitalization. I will try option 1 later. I am not very familiar with actions yet

builderjer commented 1 year ago

I found a work around that is perfect. I will close this now. Thanks for your help and quick responses