uskudarli / cmpesweng2014group6

Automatically exported from code.google.com/p/cmpesweng2014group6
0 stars 0 forks source link

Code review request #64

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Branch name: Master

Purpose of code changes on this branch: Login, register, profile edit 
functions, and functionality of map pins

When reviewing my code changes, please focus on: doGet and doPost methods of 
corresponding servlets, functionality of views and actions to write db

Please review my code and write comments below.

Original issue reported on code.google.com by faziletc...@gmail.com on 2 Dec 2014 at 9:01

GoogleCodeExporter commented 8 years ago

Original comment by serkan.b...@gmail.com on 3 Dec 2014 at 5:32

GoogleCodeExporter commented 8 years ago
Register.java
- System.currentTimeMillis() function can be used for generating Unix time 
stamps. Other than that the code is clear enough to follow. 
Login.java
- Maybe it would be a good idea to present the DataBaseService upper in the 
code. But its just a suggestion. Session handling is clear. 
ProfileEdit.java
- Both of the methods doGet and doPost are quite clear and readable. The 
approach is also quite similar to Login.java and Register.java thus enabling me 
to read it easily.

Well done :))

Original comment by serkan.b...@gmail.com on 3 Dec 2014 at 5:51

GoogleCodeExporter commented 8 years ago

Original comment by serkan.b...@gmail.com on 3 Dec 2014 at 5:51