search

uskudnik / amazon-glacier-cmd-interface

Command line interface for Amazon Glacier
MIT License
374 stars 100 forks source link

Fixing resuming with uploadid #100

Closed stigger closed 11 years ago

stigger commented 11 years ago

Amazon returns inclusive byte ranges, so in order to resume to work correctly we need to increase the "stop" variable, otherwise hashes don't match and worker.uploaded_size has incorrect value.

uskudnik commented 11 years ago

Can't test ATM, but looks reasonable since we do things like [start:stop] and for python that means stop-1.

uskudnik commented 11 years ago

Hmm... looking a bit more thoroughly - are you sure this is OK for .read(stop-start) and similar calls? Maybe we should just change https://github.com/stigger/amazon-glacier-cmd-interface/blob/c1c253fc0a9384adfea052f6733144848dc83cbc/glacier/GlacierWrapper.py#L1019 to [start:stop+1] ?

stigger commented 11 years ago

I'm sure. I've uploaded 100 gigabytes of data in ~20 files, works correctly.

offlinehacker commented 11 years ago

I am rewriting upload funcionalty, it will work. On Nov 9, 2012 7:09 PM, "Vyacheslav Karpukhin" notifications@github.com wrote:

I'm sure. I've uploaded 100 gigabytes of data in ~20 files, works correctly.

— Reply to this email directly or view it on GitHubhttps://github.com/uskudnik/amazon-glacier-cmd-interface/pull/100#issuecomment-10238795.