GlacierWrapper interface

[offlinehacker]

First of all i don't recommend puling this in master, but if you create new branch we can pull that in. Even if you pull that in master, you won't hurt anybody, because all relevant files are untouched.

I am implementing GlacierWrapper interface with proper exception handling and documentation. Later when boto is complete it should be very easy to modify only this wrapper and most of the things on the user side should work.

I recommend to continue work on any bigger changes here. I know it's untested and uncomplete, but i think it's the right way to do from here or I will have to copy paste and rewrite too much code latter.

This is actually part of implementation of #25 and #21.

Thanks!

PS: If you think some things, especially how exceptions are handled, should be implemented differently please do tell me now. I'm implementing such precise way of handling, because latter testing will be easier and users will be provided with richer error response codes.

[uskudnik]

I'm all for precise exceptions :) I skimmed through this and it looks splendid.

As for branch bureaucracy - I believe this should go into botoonly branch and we make the appropriate changes here?

[offlinehacker]

Thanks! Shure it's okay to merge with botoonly. Can you change the destination branch here, because i can't?

[offlinehacker]

I think basic, missing sdb support should be put into master, and then we continue work in botoonly? Also i won't continue to implement additinal wrapper functions until sdb support is completed, but i will try to write some tests to test functionality.

[uskudnik]

Just for the record - unless github changed things since February only you can do it when you issue pull request - see http://stackoverflow.com/questions/9135913/merge-pull-request-to-a-different-branch-than-default-in-github.

I'm off to bed now but I'll merge by hand in the morning if nothing else.

[offlinehacker]

" The submitter can change that when they issue the pull request, but once they issue it you can't change it."

Looks like merging by hand will be the best alternative. Thanks! On Sep 15, 2012 2:23 AM, "Urban Škudnik" notifications@github.com wrote:

Just for the record - unless github changed things since February only you can do it when you issue pull request - see http://stackoverflow.com/questions/9135913/merge-pull-request-to-a-different-branch-than-default-in-github.

I'm off to bed now but I'll merge by hand in the morning if nothing else.

— Reply to this email directly or view it on GitHubhttps://github.com/uskudnik/amazon-glacier-cmd-interface/pull/30#issuecomment-8580095.

[uskudnik]

This should be it: https://github.com/uskudnik/amazon-glacier-cmd-interface/commit/c0146e7917e887d6e412a2a799c605474c3beae6

Yes, updating sdb cache from inventory-retrieval should be put into master, other changes should go into botoonly branch.

Closing.