Reading configuration - wrong order.

[wvmarle]

Another issue spotted in reading the configuration:

glacier.py:545

if config.read([args.conf, os.path.expanduser('~/.glacier')]):

ConfigParser.read() priority is low to high, meaning the command line is overridden by the config file. That's not correct behaviour, command line options should override the configuration file.

Also I want to suggest adding a system wide configuration file, e.g. /etc/glacier.cfg where system defaults can be stored. This is great for people like me who call this script after finishing creating a backup (using bacula) to upload the backup archive to glacier.

Suggest changing glacier.py:545 to:

if config.read(['/etc/glacier.cfg', os.path.expanduser('~/.glacier'), args.conf]):

What this should do now:

• try to read system-wide glacier.cfg file, and take configuration arguments from that file.
• try to read .glacier file from current user's home directory, overriding system wide arguments.
• handle command line arguments, overriding any config file arguments.

[offlinehacker]

I will fix this, but why don't you make pull request?

[wvmarle]

New to Github; haven't figured it all out yet!

[offlinehacker]

Okay no problem, will fix this and add support for global config file.

[wvmarle]

Resolved; closing.