uskudnik / amazon-glacier-cmd-interface

Command line interface for Amazon Glacier
MIT License
374 stars 100 forks source link

Glacier lib #52

Closed wvmarle closed 12 years ago

wvmarle commented 12 years ago

class log_class_call(object): renamed "enter" to "start" and "exit" to "finish" as that describes them better, and "exit" is a reserved word so should not be used as variable name.

General:

uskudnik commented 12 years ago

The majority of all changes from this branch seem to be in the master or in other pull request already. As I am informed https://github.com/wvmarle/amazon-glacier-cmd-interface/commit/e7d6bf782e6f4aa2d44b5cf1d36729e02cd38491 is causing quite some problems for @offlinehacker (he tried to cherry-pick the changes) so for the time being I will close this one without merging.

@wvmarle While git's own documentation can be quite tiresome sometimes, Github did write quite nice documentation regarding both git itself and its concepts and how github operates. I would point you to https://help.github.com and https://github.com/training/free to take a peak or spend a couple of hours and get better understanding of how git and github operates. You're changes are very nice and a nice addition to the project and @offlinehacker is doing his best cherry picking changes but it would be a lot faster work for all of us and for getting changes into production if we would all follow github protocol :)

Basically what you need to do is not to merge our branches into yours but vice versa - make a branch out of one of ours (master/botoonly), make changes and make a pull request that will then be merged.

uskudnik commented 12 years ago

One last thing that I forgot before and remembered later - if you use OS X or Windows, Github has quite nice clients - see http://mac.github.com/ and http://windows.github.com/.

Hope it helps :)