search

uskudnik / amazon-glacier-cmd-interface

Command line interface for Amazon Glacier
MIT License
374 stars 100 forks source link

Glacier lib #54

Closed wvmarle closed 12 years ago

wvmarle commented 12 years ago

Many small changes made while reading through this code.

I see github says I want to merge into uskudnik:master?! This is supposed to go to the glacier_lib branch.

uskudnik commented 12 years ago

@wvmarle I know you complained about github mistargeting the pull request - is that still the case or do you consider this ready to be merged into master?

wvmarle commented 12 years ago

Almost ready; search function is broken, that's the only thing that really needs fixing that I know of. Probably just some keywords wrong but haven't really looked into it. And I haven't tested downloads on big files, just a small one (for time reasons). It should work but I prefer having block download just like block upload, allowing for resumption.

For merge into master, a few things have to be done: 1) fix search (will try to do that tonight). 2) update documentation: new functions, changed functions, logging, running in background - a lot has changed. 3) have at least one of you guys give it a serious test run, maybe some other issues come to light.

And there is one bug (not exactly a show stopper but it bugs me so to say):

$ glacier-cmd listjobs NonExisitingVault Gives neat error message.

$ glacier-cmd inventory NonExistingVault Gives stack trace (shouldn't do this) Error message

And the interesting thing is that inventory calls listjobs to check on running inventory jobs, which throws the exception as the vault doesn't exist, and then results in a different output on the screen. I tried my best to have NO stack traces on exceptions we throw, instead just print a nice message to inform the user what is going on (the stack trace goes in the log at DEBUG level).

uskudnik commented 12 years ago

Hm OK, do you need my help with anythings except the testing (maybe search)? I'm currently at a conference in Amsterdam but will probably have some time tomorrow and could try to take a look or merge it into master if its ready?

wvmarle commented 12 years ago

Search fixed, except for quotes part (opened separate issue for that).

Code is what I am concerned ready to merge back into master (effectively replacing it - not much is still original). Documentation needs work. I don't know of any serious issues now.

wvmarle commented 12 years ago

Documentation is now up to date, though I don't really like the overall layout and so. Cosmetic changes are needed. And found a bug in the display of inventory taking results, fixed that.

Tonight will do some more testing, see if I can find any more bugs. It seems to be all working OK now.

Next steps: fix the upload code, and add a command to take a tree hash of a local file. Then at least one can compare hashes after the fact.

uskudnik commented 12 years ago

Merged with @f7919f6