Closed stigger closed 11 years ago
I've skimmed through change log and nothing fell out as too bad or unconventional, except maybe for printing (various locations, but as an example): https://github.com/jamessthompson/amazon-glacier-cmd-interface/compare/sdb_config_support#L1R555
Most of the printing is done in GlacierWrapper and should probably be put there (unless of course you are only using this now during development, in which case, ignore me :))
Thanks for helping out!
Cheers, Urban
On Feb 4, 2013, at 01:57 , James Thompson notifications@github.com wrote:
I've started adding in support for this as a way of learning the code base. I was hoping one of the devs could look at https://github.com/jamessthompson/amazon-glacier-cmd-interface/compare/sdb_config_support and let me know if I'm heading in the right direction. Thanks
— Reply to this email directly or view it on GitHub.
The printing is just me verifying things during development, same with the call to exit(). I'll try to wrap it up and submit a pull request soon. Thanks
Typo in README.md line 55: secret_key=your_sdn_secret_key
I suppose this should be secret_key=your_sdb_secret_key
By the way, why separate access keys for the sdb and the glacier? You want to allow use of different AWS account for these two services?
Fixed the typo. Thanks.
I wasn't certain on the dual accounts but I figured since I was adding the region support it wouldn't be much more effort in allowing different access keys.
Feature implemented, merged @jamessthompson commit as it implemented reading from configuration file as well.
I've started adding in support for this as a way of learning the code base. I was hoping one of the devs could look at https://github.com/jamessthompson/amazon-glacier-cmd-interface/compare/sdb_config_support and let me know if I'm heading in the right direction. Thanks