search

usmanatron / amBXPeripheralController

Server application (with a number of assisting clients) to control amBX gaming peripherals
Other
2 stars 4 forks source link

Remove Light\Fan\RumbleActor classes #16

Closed usmanatron closed 9 years ago

usmanatron commented 9 years ago

Currently we have a LightActor, FanActor and RumbleActor. All of these are very similar EXCEPT for the method they call on IEngine. This extra level adds unnecessary complexity. A way to remove this is to absorb it into the engine (perhaps a method which infers from the IComponent being passed around; use reflection?).

Also see if this idea can be extended to the Conductors and other similar cases

usmanatron commented 9 years ago

As per issue 17, a side effect of these changes is to move the FadeTime from every Section to just the lights (this is only used by the lights, plus it will allow for some cool effects potentially)

usmanatron commented 9 years ago

Fixed through ISSUE-16 branch