Clean up ConductorManager

usmanatron / amBXPeripheralController

Server application (with a number of assisting clients) to control amBX gaming peripherals

Other

1 stars 4 forks source link

Clean up ConductorManager #5

Closed usmanatron closed 10 years ago

usmanatron commented 10 years ago

There are a load of Light\Fan\Rumble Conductor methods in here (i.e. one for each type). This is because it won't currently allow a more generic one (for reasons not yet entirely understood). Need to:

Understand why it isn't happy
do something to reduce commonise this as much as possible. Ideally have the one method for all conductors (inc. Frame)

usmanatron commented 10 years ago

Done - hooray! Added an IConductor and, after much head-scratching, made it happy. Now the FrameConductor shares some of these too. One limitation: FrameConductors now have a ComponentType (which makes no sense). Currently throws an InvalidOperationException - should consider if theres a better way though, for now, much happier :-) (on ServerDI branch)