Browserification - Githubissues

whroman commented 9 years ago

Got bored at the airport ;) Feel free to disregard

Changes worth noting

Browserify is now being used to compile client code. This includes third party scripts, which are now being managed by npm. I tried not to mess with the logic of the js scripts very much. I'll leave that up to you. This "browserify" Grunt task replaces the "concat" task and it also outputs a sourcemap.
I noticed that an uglification task was in place but wasn't being used. I put it in place and the prod build.js file went from 1mb to 100kb, which is great! However, I don't know how to test a prod build.
Misc cleanup
- Added an nvmrc as InstaTab is incompatible with older versions of Node.
- Removed src/inject dir, as it didn't seem to affect or be used by anything.

whroman commented 9 years ago

@usmanity This PR breaks existing test coverage due to issue https://github.com/usmanity/instatab/issues/26

usmanity commented 9 years ago

Thanks for the pull request, I will merge and work on this as part of v3 release for InstaTab, meaning it'll be a good starting point for a better written extension! :+1:

usmanity / instatab

Browserification #27

Changes worth noting