search

usmannasir / cyberpanel

Cyber Panel - The hosting control panel for OpenLiteSpeed
GNU General Public License v3.0
1.53k stars 592 forks source link

[BUG] Never ending addition of txt records and mx records to DNS #1124

Closed cagivacode closed 1 year ago

cagivacode commented 1 year ago

Describe the bug For a long time with multiple builds there are duplicate txt records and MX records being added to the dns (I think during the cert renewal process)

If I don't regularly clear them out there will be dozens of them and they directly contradict the ones I need.

involves: spf, dmarc and domainkey. Also extra MX records.

this happens to all of my domains.....I DO NOT use cloudfare.

To Reproduce Just check into the dns records after time has past and these entries are there.....

Expected behavior I have needed dmarc / domainkey and specific spf records that are being ignored....cyberpanel should respect those records.

I use dmarc reject. I use a valid domainkey. My outgoing mail is through mailchannels so I require a specific SPF record.

All the extra MX records is just a plain bug.

Operating system: This issue has occured for awhile now...cleaning up screenshots for posting is just a pain.

Started on my original system (vps) running centos 7. I used export/import to move all domains to Ubuntu 22.04 but have had the same issue.

CyberPanel version: has been this way for sometime now I am running the lastest version 2.3.4 "Latest Commit: d65b6b5bcd4e89ce1a0eeb74131f98093e85bb3a"

here are screenshots:

cyberp_dns_txt

cyberp_dns_txt2

master3395 commented 1 year ago

I have the same issue, i had a subdomain.domain.com posted as a normal website, not as a subdomain, and it made DNS records. I deleted the whole website (That was a subdomain), yet the DNS records for SSL is still asking each time Let's Encrypt is trying to update the SSL.

As seen in this image, dashboard.newstargeted.com is no longer a domain. I have deleted the Cloudflare records manually, since CyberPanel does not delete CyberPanel records, only making them. image

Damperen commented 1 year ago

I have the same issues.

irockbot commented 1 year ago

I have already reported this to cp team here https://github.com/usmannasir/cyberpanel/issues/1059

They have closed it without fixing it and ignoring like anything. @usmannasir

cagivacode commented 1 year ago

Another three week...I had to clear out several hundred of these txt records today.

This is a security issue..in that CP keeps adding dmarc = none txt records when I require Dmarc= reject

irockbot commented 1 year ago

@cagivacode Yes! You will even find A record cptest. They are not answering what is this all about and what is behind this secret security loopholes.

usmannasir commented 1 year ago

I am going to look into this, sorry for not replying as i was traveling and not in the home country.

usmannasir commented 1 year ago

The commit I made above should solve this problem, this code is in v2.3.5-dev branch for now.