search

usmannasir / cyberpanel

Cyber Panel - The hosting control panel for OpenLiteSpeed
GNU General Public License v3.0
1.53k stars 592 forks source link

Fix https://github.com/usmannasir/cyberpanel/issues/842 #1155

Closed Lvl4Sword closed 10 months ago

Lvl4Sword commented 10 months ago

As said in https://github.com/usmannasir/cyberpanel/issues/842#issuecomment-1816840750 , there's no reason not to have this as a list.

Lvl4Sword commented 10 months ago

Noticed the ip file is read within listWebsitesJson, but is never closed. with open() ensures the file is closed without needing to explicitly call .close()

Lvl4Sword commented 10 months ago

I'm unsure as to why checker is here, let alone why the ip file is even being read, since neither seem to really be used for anything. since it doesn't seem to be used. The ip is used, because that needs provided to the user.. lol

xmok commented 10 months ago

Though not directly related to your PR, Issue #1145 I've opened deals with fixing JSON in the cloudApi which does relate to your previously opened Issue #842. Would be nice to get some feedback from the team on this as I've observed fixing the JSON handling also fixed some other minor errors thrown in the dashboard.

usmannasir commented 10 months ago

I had to change the base for this merge, thanks.

Lvl4Sword commented 10 months ago

Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well.

usmannasir commented 10 months ago

You have any pending PR?

If now I've no problem reviewing new and merging.

thank you.

Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well.

Lvl4Sword commented 10 months ago

Not currently, but it'll be worked on this week. Glad to help! 👍

You have any pending PR?

If now I've no problem reviewing new and merging.

thank you.

Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well.

usmannasir commented 10 months ago

Here to help.