search

usmannasir / cyberpanel

Cyber Panel - The hosting control panel for OpenLiteSpeed
GNU General Public License v3.0
1.48k stars 577 forks source link

[BUG] CyberPanel attempts to renew SSL for Suspended domains #1172

Open hbrawdy opened 6 months ago

hbrawdy commented 6 months ago

The update script renew.py attempts to renew all SSL certificates for all websites on the server, even if the websites have been suspended. This forced a delay and a self-signed certificate, as well as a failure email to root.

To Reproduce

  1. create a website ( MYTESTSITE.COM )
  2. generate LetsEncrypt SSL certificate for website
  3. suspend website
  4. on renewal, LetsEncrypt fails, CyberPanel generates self-signed SSL

Expected behavior renew.py should only loop through websites that are not suspended.

Operating system: Centos 7

CyberPanel version: Current Version: 2.3 Build: 4 Current Commit: c8da443334b8815ec250a0fba606e75355f641cd

cagivacode commented 6 months ago

I have to agree with this, I have a test site (a sub domain) that I use to demo web designs. I keep it suspended when I have no projects in the pipeline, and when the Cert expires there is an endless retry, which of course fails because the website itself is suspended. I have resorted to unsuspending the test site every couple of months to get around this.