usmannasir / cyberpanel

Cyber Panel - The hosting control panel for OpenLiteSpeed
GNU General Public License v3.0
1.53k stars 591 forks source link

Upgrade overwrites root's crontab #261

Closed gabrielcossette closed 4 years ago

gabrielcossette commented 4 years ago

Hi,

Now the latest upgrade script adds the cyberpanel related tasks to root's crontab... but overwrites any custom tasks that were already there :(

Please adjust the upgrade script so that cyberpanel tasks are instead added if they are not already there.

Thanks!

usmannasir commented 4 years ago

Hello @gabrielcossette

I just checked and it is not the case. Seems custom Cron jobs are preserved. Kindly provide ways to reproduce the problem.

cagivacode commented 4 years ago

I thought I had seen this issue before it had been closed....how to reproduce??? on Centos 7.8

My /var/spool/cron/root file was:

# 17 0 * * * "/root/.acme.sh"/acme.sh --dns --cron --home "/root/.acme.sh" > /dev/null
MAILTO = ""
27 4,9,14,19 * * * /usr/local/bin/automysqlbackup /etc/automysqlbackup/automysqlbackup.conf #mysql backup
# 6 8 * * * /usr/bin/find /media/volsoft/system_dd -type f -iname "*.tar.gz" -mtime +15 -delete
7 20 * * * df -h| grep 'Filesystem\|/dev/[s m]da*' | mail -r "me@home.net" -s "Arrow Disk Report" me@home.net
1 20 * * 2 du -chs /media/volsoft/* | sort -rh | head -8 | mail -r "me@home.net" -s "Arrow Disk Report" me@home.net
3 20 * * 2 du -chs /media/volmega/* | sort -rh | head -8 | mail -r "me@home.net" -s "Arrow Disk Report" me@home.net
# 8 * * * /usr/bin/find /media/volsoft/ftp -type f -iname "*.tar.gz" -mtime +30 -delete
7 7 4,19 * * /usr/sbin/xfs_fsr -t 14400 /dev/md0 >/dev/null 2>&1
7 7 5,20 * * /usr/sbin/xfs_fsr -t 14400 /dev/sda >/dev/null 2>&1
32 14 4,11,18,25 * * echo "check" > /sys/block/md0/md/sync_action

after upgrade (starting with the pre-upgrade script)..... /var/spool/cron/root contains this (with the blank line and part of the disabled acme.sh job missing):


0 * * * * /usr/local/CyberCP/bin/python /usr/local/CyberCP/plogical/findBWUsage$
0 * * * * /usr/local/CyberCP/bin/python /usr/local/CyberCP/postfixSenderPolicy/$
0 0 1 * * /usr/local/CyberCP/bin/python /usr/local/CyberCP/postfixSenderPolicy/$
0 2 * * * /usr/local/CyberCP/bin/python /usr/local/CyberCP/plogical/upgradeCrit$
0 2 * * * /usr/local/CyberCP/bin/python /usr/local/CyberCP/plogical/renew.py >/$
# 7 0 * * * "/root/.acme.sh"/acme.sh --cron --home "/root/.acme.sh" > /dev/null

0 12 * * * /usr/local/CyberCP/bin/python /usr/local/CyberCP/IncBackups/IncSched$
0 0 * * 0 /usr/local/CyberCP/bin/python /usr/local/CyberCP/IncBackups/IncSchedu$

It may have to do with the disabled jobs...not sure. Hope this helps, RDL