Feature request - use device name when creating backups

usnasoft / shellyscanner

Shelly Scanner source code

https://www.usna.it/shellyscanner/index_en.html

GNU General Public License v3.0

35 stars 7 forks source link

Feature request - use device name when creating backups #11

Closed gouthamravee closed 1 month ago

gouthamravee commented 3 months ago

Thank you so much for creating this awesome tool, its config backup is my primary use case for this tool.

It would be a hell of a lot more useful if the config backup feature could create backups using the device's friendly name if it is set.

usnasoft commented 3 months ago

There are some reasons I use the device hostname:

The hostname is unique for sure so no accidental overwrite is possible (there are alternative solutions for this);
if the friendly name changes I can always suggest the correct file name on restore;
if you do restore after a reset (the most frequent case I think) the device will not have the friendly name before restore but Shelly Scanner can still suggest the correct file name.

Do I convinced you? If not I could work to an option on application settings in the future.

gouthamravee commented 3 months ago

You make damn solid points.

The problem I have is trying to figure out which host names goes to what since all my shellies have host names like shelly1pm-84CCA8B01B93 and shelly1pm-B98798, maybe that's a difference between gen 1 and newer gen devices.

But I just realized that the restore process would use shelly scanner too, so I wouldn't have to worry about finding the correct shelly to restore to.