search

usnationalarchives / OPAProd

Tracking enhancements to OPAProd
1 stars 0 forks source link

Popups should close with escape key or clicking outside #63

Open DominicBM opened 9 years ago

DominicBM commented 9 years ago

There are some popups which do not close by either hitting the escape key or clicking outside the lightbox. The most obvious of these is the contributions workspace. We may need to do testing to check for others.

mereastew commented 9 years ago

Is it desired behavior for the popup to close when clicking outside? I'm just thinking for contributions if you're in the middle of something. However, if you click escape or click outside and you were editing, then it should probably warn you with the secondary popup before you leave.

DominicBM commented 9 years ago

Yes, I thought there was already a warning if you attempt close with unsaved text? I think that clicking outside to close is normal behavior for lightbox-type popups like we are using, but I agree it should not allow errant clicks to destroy users' work.