search

usnationalarchives / nara-bia-photos

0 stars 0 forks source link

Tribal Nation drop down HTML issue #256

Closed lizzycederberg closed 3 years ago

lizzycederberg commented 3 years ago

The select featured tribal nation dropdown doesn’t follow the intuitive tabbing order because, though it appears “first” in the content, it is second in the html. As with the other dropdown, it is missing the focus indicator.

matbrady commented 3 years ago

@lizzycederberg they seem to be flagging two issues here.

As with the other dropdown, it is missing the focus indicator.

can this be broken into another ticket?

lfrancis commented 3 years ago

See #254 for the select issue.

As for the intuitiveness of the html order, it seems pretty intuitive to me:

image

lfrancis commented 3 years ago

However, I'm noticing that the content is not being announced by VoiceOver from the top of the page, probably because the Tribal Nations page link is in focus when the dialog is activated:

image

lizzycederberg commented 3 years ago

@lfrancis can you please validate these?

lizzycederberg commented 3 years ago

Also @matbrady I would rather just change the order of these instead of going back to them on this. If they think it's in an unintuitive order, then we should defer to them.

lfrancis commented 3 years ago

Confirmed fix for focus and accessibility of dialog content on https://bia.test.drupalme.net/research/native-americans/bia/photos/

@lizzycederberg, with this accessibility fix the client's concern about intuitiveness is no longer relevant.