usnationalarchives / nara-ugfa

NARA User Generated Finding Aids Prototype
1 stars 0 forks source link

button element is empty and has no accessible name. #139

Closed lfrancis closed 4 years ago

lfrancis commented 4 years ago

This button element is empty and has no accessible name. WCAG 2.0 A 4.1.2 Section 508 (2017) A 4.1.2 1 pages A programmatically determined name allows screen readers to tell users what the control does. To add a name do one of the following:

Add text between the button start and end tags Add a title attribute Add an aria-label attribute Add an aria-labelledby attribute Add an img alt attribute if the button contains an img element

https://nara-ugfa.herokuapp.com/search?q=bush Line 58 148 157 171 178

<button type="submit" value="Submit" class="sc-fzoCUK cYKdOK"> <button disabled="" class="sc-fzoXzr cayXyQ"> <button disabled="" class="sc-fznxsB kViHWY">

etc

danielboggs commented 4 years ago

@lfrancis I believe the icon-only pagination and search submit buttons were the culprits here. I have added screenreader-only text to those buttons.

lfrancis commented 4 years ago

Confirmed addressed