search

usnationalarchives / nara-ugfa

NARA User Generated Finding Aids Prototype
1 stars 0 forks source link

Whither loading...? #161

Closed lfrancis closed 3 years ago

lfrancis commented 3 years ago

Is there supposed to be a latency loading animation, or is this deemed good enough fro a prototype?

image

lfrancis commented 3 years ago

If we're just going to go with text then we should at least add a little padding to the left so it's not awkwardly banging into the edge.

danielboggs commented 3 years ago

@lfrancis I have updated many instances of "page-level" loading with a spinning indicator and updated styles.

lfrancis commented 3 years ago

Confirmed addressed

lfrancis commented 3 years ago

Oops, can we add it to the login screen, too?

danielboggs commented 3 years ago

I just checked this out and it looks like it is in place on the login page. It will only display if you havent already visited a page and dont have the appropriate javascript bundle downloaded for the page/section.

lfrancis commented 3 years ago

I just checked this out and it looks like it is in place on the login page. It will only display if you havent already visited a page and dont have the appropriate javascript bundle downloaded for the page/section.

oops, sorry, I meant so that you get the spinner after successfully submitting your credentials, so I guess that means the dashboard page.

danielboggs commented 3 years ago

@lfrancis this has now been added to the dashboard page as well.

lfrancis commented 3 years ago

Confirmed addressed