Comment entry not accessible by kybd

usnationalarchives / nara-ugfa

NARA User Generated Finding Aids Prototype

1 stars 0 forks source link

Comment entry not accessible by kybd #175

Closed lfrancis closed 3 years ago

lfrancis commented 3 years ago

https://nara-ugfa.herokuapp.com/guides/34/edit

I can't appear to add text to an open comment field via keyboard. We could potentially hide this from screenreader users but still need kybd control for mobility-challenged users:

danielboggs commented 3 years ago

Leaving a note for myself. There seems to be a bug where the popover component is not using the custom destination element and is creating an issue with DOM-ordering, making it hard to reach focus on the form input for comments.

danielboggs commented 3 years ago

I have made an update so that focus swaps to the commenting toggle button when this UI opens. This makes it so that subsequent tabs will immediately take you into the commenting UI.

lfrancis commented 3 years ago

I can now navigate to and edit already existing comments via kybd, but I cannot create new comments as the dialog doesn't appear:

comment de adieu

danielboggs commented 3 years ago

@lfrancis adding new comments should now be working again.

lfrancis commented 3 years ago

Confirmed addressed