search

usnationalarchives / nara-ugfa

NARA User Generated Finding Aids Prototype
1 stars 0 forks source link

Buttons must have discernible text [submit] #193

Closed lfrancis closed 4 years ago

lfrancis commented 4 years ago

https://nara-ugfa.herokuapp.com/guides/39/edit

Buttons must have discernible text

Impact: critical

Issue tags category: name-role-value wcag2a wcag412 section508 section508.22.a

Issue description Ensures buttons have discernible text

Element location .sc-plVjM Element source <button type="submit" class="sc-plVjM dhmRPe"></button>

To solve this violation, you need to... Fix at least one (1) of these issues: Element does not have inner text that is visible to screen readers

aria-label attribute does not exist or is empty

aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty

Element's default semantics were not overridden with role="presentation"

Element's default semantics were not overridden with role="none"

Element has no title attribute or the title attribute is empty

danielboggs commented 4 years ago

Having a hard time pinpointing this. I cant seem to find any empty button tags on this page and the class names above are randomly generated at build time and appear missing from the page now. @lfrancis is it possible to re-test this and actually pinpoint which UI element is the offender?

lfrancis commented 4 years ago

Hmm, those are Axe reports, let me see if SortSite gives a better clue.

lfrancis commented 4 years ago

Here's what SortSite flags:

113 <input id="coverImage" placeholder="Enter Catalog URL" name="catalogUrl" class="sc-fzomuh sc-pYNsO gnIlcU" value=""> 114 <button type="submit" class="sc-ptdsS cVqkMT"></button> <---

danielboggs commented 4 years ago

@lfrancis that was helpful!

This should now be resolved.

lfrancis commented 4 years ago

Confirmed addressed