search

usnistgov / ACVP-Server

A repository tracking releases of NIST's ACVP server. See www.github.com/usnistgov/ACVP for the protocol.
46 stars 16 forks source link

multiple ParallelHash MCT issues #212

Open markowitz-isc opened 2 years ago

markowitz-isc commented 2 years ago

vsId PARALLELHASH-128-1.0/prompt.json and PARALLELHASH-256-1.0/prompt.json

Description of Problems

  1. Several of the ParallelHash MCT test group properties appearing in these sample prompt files are not defined in the spec (draft-celi-acvp-xof.html#name-test-groups): minBlockSize, maxBlockSize, minOutLen, and maxOutLen. As they appear to simply echo capabilities registration properties, they're probably unnecessary here.
  2. OTOH, they're referenced in the ParallelHash MCT pseudocode so it's not clear whether they're supposed to be hardcoded in the IUT or read from the prompt file.
  3. The server seems to ignore the MCT test case blocksize property (which strangely enough can be larger than maxBlockSize) and instead uses the group's minBlockSize (as specified in the pseudocode!)... which makes one wonder why there's a blocksize test case property at all. (See draft-celi-acvp-xof.html#name-parallelhash-monte-carlo-te.)
livebe01 commented 2 years ago

Sorry we haven't had a chance to get to this yet. Just letting you know that we haven't missed it.

jbrock24 commented 1 year ago

Hi @markowitz-isc!

  1. These were missing and added to the docs late June. Thanks for letting us know!
  2. They are meant to be read on a per-case basis by the testing harness.
  3. The group's blocksize (a MathDomain object from registration) is used for the Generation's Hash method, the result's seed's BlockSize is saved to the TestCase as BlockSize (int) for use within the testing harness on a per-case basis.
livebe01 commented 1 year ago

Reopening as item #3 appears to be valid