usnistgov / ACVP-Server

A repository tracking releases of NIST's ACVP server. See www.github.com/usnistgov/ACVP for the protocol.
46 stars 16 forks source link

Spec is incorrect for TupleHash and ParallelHash #213

Closed powersmc closed 1 year ago

powersmc commented 2 years ago

environment Demo (probably affects Prod as well though)

testSessionId N/A

vsId N/A

Algorithm registration

            {
                "algorithm": "TupleHash-256",
                "revision": "1.0",
                "xof": [
                    true,
                    false
                ]
                ,
                "hexCustomization": false,
                "outputLen": [
                    {
                        "min": 16,
                        "max": 65536,
                        "increment": 8
                    }

                ]
                ,
                "msgLen": [
                    {
                        "min": 0,
                        "max": 65536,
                        "increment": 8
                    }

                ]

            }

Endpoint in which the error is experienced /testSessions POST

Expected behavior Based on the spec here; https://pages.nist.gov/ACVP/draft-celi-acvp-xof.html#appendix-A https://pages.nist.gov/ACVP/draft-celi-acvp-xof.html#table-3

The server should accept the "camel case" algorithm names TupleHash-128, TupleHash-256, ParallelHash-128, ParallelHash-256.

It does not accept these names, however, and it seems to only accept TUPLEHASH-128, TUPLEHASH-256, PARALLELHASH-128, PARALLELHASH-256, which don't appear in the spec at all.

Additional context No additional context

livebe01 commented 2 years ago

Thanks for letting us know about this @powersmc

livebe01 commented 2 years ago

We would like the casing for the two xofs to be TupleHash and ParallelHash to match SP 800-185, however, the server currently requires the algorithm names to be all caps. We would also like the casing to be cSHAKE, but the server currently requires CSHAKE. We will address this in an upcoming server release.

livebe01 commented 2 years ago

The fix for this is now on Demo, v1.1.0.25.

livebe01 commented 1 year ago

The fix for this is now on Prod in release v1.1.0.25.