usnistgov / ACVP-Server

A repository tracking releases of NIST's ACVP server. See www.github.com/usnistgov/ACVP for the protocol.
46 stars 16 forks source link

Issue testing KAS-IFC with val + responder tests #217

Closed abkarcher closed 1 year ago

abkarcher commented 2 years ago

environment Demo

testSessionId 259262

Hello,

I have been trying to debug a harness implementation of KAS-IFC, specifically an issue where some VAL tests with a "responder" role were failing with the reason "FailChangedZ". Libacvp is detecting that the tests passed.

I think I may have isolated a possible cause, related to (pending) changes I made after https://github.com/usnistgov/ACVP/issues/1338.

After that conversation, I have changed the library side of libacvp to make comparisons against hashZ when a hash function is provided, and ignore the provided Z value; the Z value seemed to be redundant and caused extra complexity in the client.

However, with this particular failure reaason "FailChangedZ", my idea is that the server is altering the Z value to cause a failure in the VAL test, but not altering the hashZ value. Thus, I am not able to pass the test properly. If this is the case, could the behavior be modified so the hashZ value also gets modified?

I could be wrong; I have been looking at this code for a bit too long now :) Any help isolating this issue would be greatly appreciated!

Thanks, Andrew

livebe01 commented 2 years ago

Hi @abkarcher, At first look, I think you might be right on this. But let me dig deeper to verify that I'm understanding correctly what I'm looking at.
Thanks, Ben

abkarcher commented 1 year ago

Hi,

Is there any update on this? I only ask because it will require me to redo some libacvp code in the coming month or two if the raw Z value is required.

Thanks, Andrew

livebe01 commented 1 year ago

Yes! We plan to have a fix for this in the next week or two. We'd like to send a new release to Demo next week if possible. Sorry for the wait on this.

abkarcher commented 1 year ago

Thanks for the update 😄

Andrew

livebe01 commented 1 year ago

This change is on Demo in release v1.1.0.26

livebe01 commented 1 year ago

This change is on Prod in release v1.1.0.26