search

usnistgov / ACVP

Industry Working Group on Automated Cryptographic Algorithm Validation
https://csrc.nist.gov/projects/cryptographic-algorithm-validation-program
162 stars 65 forks source link

Update 06-eddsa-siggen-test-vectors.adoc #1500

Closed jvdsn closed 6 months ago

jvdsn commented 6 months ago

Cf. https://github.com/usnistgov/ACVP-Server/blob/master/gen-val/src/generation/src/NIST.CVP.ACVTS.Libraries.Generation/EDDSA/v1_0/SigGen/TestCase.cs#L22

jvdsn commented 6 months ago

Actually, I am wondering if contextLength should not also be part of the capabilities table at https://github.com/usnistgov/ACVP/blob/master/src/eddsa/sections/05-eddsa-siggen-capabilities.adoc ?

jvdsn commented 6 months ago

According to FIPS 186-5 and https://github.com/usnistgov/ACVP-Server/blob/master/gen-val/src/orleans/src/NIST.CVP.ACVTS.Libraries.Orleans.Grains/Eddsa/OracleObserverEddsaDeferredSignatureCaseGrain.cs#L54, this is in octets (bytes), not bits.

jvdsn commented 6 months ago

Actually, I am wondering if contextLength should not also be part of the capabilities table at https://github.com/usnistgov/ACVP/blob/master/src/eddsa/sections/05-eddsa-siggen-capabilities.adoc ?

Based on my testing, this parameter is also provided as part of the request, so made some commits to add it to the table and the example registration.

jbrock24 commented 6 months ago

Thank you for the help @jvdsn!