search

usnistgov / AGA8

Files associated with the AGA8 standard
Other
36 stars 21 forks source link

Build system and Travis CI for C++ version #4

Closed royvegard closed 5 years ago

royvegard commented 5 years ago

The test that is run by Travis is very simple and only tests if the executable runs and exits with success (i.e. returns 0).

We can make it a bit more useful by actually comparing the calculated parameters with the expected values and exit with failure (anything other than 0) if there is a difference that is larger than some threshold.

royvegard commented 5 years ago

I notice that this pull request also lists the three commits from the previous pull request. I'm wondering if that could happen if you are squashing all the commits into one single commit when merging. Could you try to use the default Merge pull request or the Rebase and merge option to see if that makes the next pull request more sane?

https://help.github.com/en/articles/about-pull-request-merges

ianhbell commented 5 years ago

This is really great, thank you!

Before you start working on a branch/PR, make sure you are starting your branch at master. I don't like to do merges because it leaves a lot of potentially erroneous stuff in the commit history, and I can't rebase this one due to conflicts, so squash and merge it is.