usnistgov / AusteniteCalculator

Software and GUI for uncertainty quantification of austenite phase fraction
Other
1 stars 0 forks source link

Changing Unit types doesn't update #36

Closed creuzige closed 1 year ago

creuzige commented 1 year ago

When selecting units for the phase fraction, it seems like only the first selection is used. Changing the units subsequently doesn't seem to change the values.

dnewton600 commented 1 year ago

The issue seems to be at the actual conversion code itself (not the UI or storage) around lines 1111- 1127 (ish). If you print volumne_conversion, mass_conversion, and phase_frac, they are all identical.

dnewton600 commented 1 year ago

Looks like the problem is just due to aliasing, I'll fix and push