dw13813
commented
2 years ago For [1]: the code should be doing that already. The Pseudocode was designed to check if either the real DR or nominal DR values were missing and then fill in only if the one required by the Boolean was omitted. There may be an error in implementation. I’m trying to build tests in between training sessions but haven’t found time to run them. For [2]: We can either make them not required or default them to zero and alter their values only if the user explicitly gives values. For [3]: We can autofill them, however there’s no guarantee that the user’s MARR or reinvestment rate will equal the discount rate. We could treat them as optional for now and return blank values in the case there not needed.
From: jkneifel @.> Reply-To: usnistgov/E3 @.> Date: Tuesday, October 19, 2021 at 4:47 PM To: usnistgov/E3 @.> Cc: Subscribed @.> Subject: [usnistgov/E3] Analysis Object Conditions (Issue #27)
(1) I think we should adjust the requirement for a minimum of 2 of 3 values for real discount rate, nominal discount rate, and inflation rate. Here are the conditions: If real discount rate boolean = true, then you need either the real discount rate or both the nominal discount and inflation rates (used to calculate the real discount rate). Else need 2 of the 3 to ensure you have or can calculate the nominal discount and inflation rates (2) the federal and other income tax rates should not be required because we do not use them. they are for future versions that will be designed to handle profits/taxable gains (not applicable for the current non-income calculations). (3) check to see if the code will autofill the interest rate, MARR, and reinvestment rate with the appropriate discount rate (nominal discount rate if real boolean = false and real discount rate if real boolean = true)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/usnistgov/E3/issues/27, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AANSOMBBORMJZMGGAVTTSYLUHXKMLANCNFSM5GKBT6KA. Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cdavid.webb%40nist.gov%7C91d345d245eb4f4729c008d993419bfe%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637702732282340622%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0xWxY5kTb1vA0lyLii1l5QM0jMvoBx0dHXJpDmRD%2F7c%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cdavid.webb%40nist.gov%7C91d345d245eb4f4729c008d993419bfe%7C2ab5d82fd8fa4797a93e054655c61dec%7C1%7C0%7C637702732282350575%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vyNU8lzobX9wHAiNoXqAWakjsARHyfeIlU5%2Fyx3wdD4%3D&reserved=0.
jkneifel
(1) I think we should adjust the requirement for a minimum of 2 of 3 values for real discount rate, nominal discount rate, and inflation rate. Here are the conditions: If real discount rate boolean = true, then you need either the real discount rate or both the nominal discount and inflation rates (used to calculate the real discount rate). Else need 2 of the 3 to ensure you have or can calculate the nominal discount and inflation rates (2) the federal and other income tax rates should not be required because we do not use them. they are for future versions that will be designed to handle profits/taxable gains (not applicable for the current non-income calculations). (3) check to see if the code will autofill the interest rate, MARR, and reinvestment rate with the appropriate discount rate (nominal discount rate if real boolean = false and real discount rate if real boolean = true)