search

usnistgov / ESV-Server

Entropy Source Validation Protocol and Server specifications
13 stars 12 forks source link

Entropy Source Registration File Issues #18

Closed tarcode2004 closed 2 years ago

tarcode2004 commented 2 years ago

The EntropySourceValidationProtocol.md file has an example entropy assessments JSON file with a typo and a missing required field. The example file has a comma where there should be no comma. See image attached. The "itar" field seems necessary for the application to proceed, however, is not included in the example JSON file.

When one of the fields in the Entropy Assessment JSON is missing the error provided has information pointing to the missing field. However, when "conditioningComponent" is missing the server returns a 500 response, internal service error, without context.

ESV-Err1
celic commented 2 years ago

Thanks. I can fix the documentation issues now. I'll log the 500 for a dev to tackle.

celic commented 2 years ago

It appears that if the conditioningComponents array is included but empty, everything proceeds as expected. If the array is excluded entirely, then you get the 500 error. Ideally these two cases should lead to identical behavior from the server, so we'll look at that.

celic commented 2 years ago

This is fixed on Demo.