Closed HLRichardson-Git closed 3 months ago
Thanks for this report and the fix! I am reviewing it and will make the necessary merges after some local testing.
I've tested this and everything looks good. Thank you for catching this and submitting the fix! Look for the correction in our next release.
Recently I had to use this client to submit some samples for a ESV in progress. In using this client I ran into some issues with the 'submit' run type.
First was that on line
203
the call for therunner_data
was missing therestartSampleSize
variable.Second also on line
203
therunner_data
function call was passingrawNoiseSampleSize
. This value is a list, not a value. So when the trace is followed anddf_upload_raw
is called. The check on line 62 fromthread_functions.py
if(sampleSize != -1)
was comparing if a list is equal to -1. This lead to always doing:Which passed a list instead of the intended sampleSize integer. This lead to a parsing error on line 70 from
thread_functions.py
and threw an error.To fix this I added the
restartSampleSize
argument to therunner_data
call on line 203 ofclient.py
. Secondly I copied what was done in thefull
run type and used theresponseCount
variable already present to pass:rawNoiseSampleSize[responseCount], restartSampleSize[responseCount]
which passes the values of the rawNoiseSampleSize and restartSampleSize for the respective respone instead of the list of sample sizes.I tested this with:
rawNoiseSampleSize
andrestartSampleSize
json values given in a run.demo.json.rawNoiseSampleSize
andrestartSampleSize
json values given in a run.demo.json.Additionally I added a template for the
jsons/entropy-source-metadata.json
. Documentation for this addition was not added.