usnistgov / ElectionResultsReporting

Common data format specification for election results reporting data
https://pages.nist.gov/ElectionResultsReporting
Other
23 stars 8 forks source link

adding additional filtering to OtherCounts #15

Closed johnpwack closed 6 years ago

johnpwack commented 6 years ago

I'm thinking that instead of moving CountItemType and DeviceClass filtering elements to OtherCounts, just remove the association with GpUnit, and make OtherCounts a subclass of Counts. This adds the IsSuppressedForPrivacy boolean, I don't know whether one would ever suppress the number of, say, overvotes for privacy reasons, but it's an optional item. Comments?

carl3 commented 6 years ago

John, I think you have to do that-- it just puts it back to 1.0 with a name change (no problem calling it OtherCounts). Often results are reported separately by precinct-ballots, mail-ballots, and total ballots. These include UnderVotes and OverVotes. So you need the CountItemType from the base class. As far as I know, what was in V1.0 was fine.

Detailed reports do the same with separate precinct and mail ballots, but give precinct subtotals (the GpUnit associated with the is a precinct). Making OtherCounts a subclass of Counts works for all cases.

johnpwack commented 6 years ago

All - I'll make OtherCounts a subclass of Counts today unless I hear objections.