usnistgov / ElectionResultsReporting

Common data format specification for election results reporting data
https://pages.nist.gov/ElectionResultsReporting
Other
23 stars 8 forks source link

Election Type enumerations and definitions do not match VVSG glossary #25

Closed whittsxnbq closed 4 years ago

whittsxnbq commented 5 years ago

The enumerations for Election Type, and the definitions of those types, do not match the new VVSG glossary. The glossary contains slightly different types, and in some cases such as General Election the definitions directly conflict. the VVSG Glossary definitions are more correct. Can we harmonize these? Otherwise there will be confusion in how to interpret the data provided in the feed. For example, if General Election is only for the election which takes place in November of even numbered years (based on the definition in 1500-100 v2), then any scheduled non-primary election that is not within that timeframe would be an Other Type. if we use the VVSG definition which is more broad, then any scheduled non-primary is a "general". We need to have this resolved so we know how to correctly interpret and report this field in our 1500-100 feed.

johnpwack commented 5 years ago

Thanks for the catch. I synced up with the glossary terms and the latest version is now on the server. Can I close this thread?

whittsxnbq commented 5 years ago

I'm looking at the word doc dated 12/8/2018. General Election is fixed but Open Primary, Closed Primary and Partisan Primary are still not quite right. I checked the glossary and I don't think they are quite right there either. I reported the glossary issues to Katy. Once she responds and we have those fixed in the glossary, we can update them here.

johnpwack commented 5 years ago

I've synced up definitions in 1500-100 V2 with those in the glossary; the most recent version of the spec (2019-02-01) matches up.

whittsxnbq commented 5 years ago

HI, I just looked in github, and the word version of the schema documentation still has the wrong definitions. Can you send me a link to the version on github that has the correct ones? I need to send the documentation to some people but I want to send them the correct stuff.

From: John P. Wack notifications@github.com Sent: Saturday, February 09, 2019 12:24 PM To: usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com Cc: Whitt, Sarah - ELECTIONS Sarah.Whitt@wisconsin.gov; Author author@noreply.github.com Subject: Re: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

I've synced up definitions in 1500-100 V2 with those in the glossary; the most recent version of the spec (2019-02-01) matches up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/1Xj5JnJRNSAvHQ6n_H-mm-BbKBnx2Aq9uEbiI8vvcMCQeoiWIriZH8R887fNt9UslwJ43aPzt2_JfimGQop7dK_ynHXv8bsAoZuzsKy7Xg5Q_ImAHhSenNNEMz_fajiXBgh7ejMIz2P8a8U2wVMbFUcBn-za6lJ4x7BSDavy7C12iYmgBp08RxMYksBICfRQY8M3yPusF8ZOZVzZP13-L4eRfPT3UJ86bOJlCiIGDsPygXjt9q5hv_rY4Ku-NMT8h/https%3A%2F%2Fgithub.com%2Fusnistgov%2FElectionResultsReporting%2Fissues%2F25%23issuecomment-462067303, or mute the threadhttps://secure-web.cisco.com/1eLyr0TbsqHTfrVmlHuslPFTD_toMhOf80Dguep0MrmrGL3l6hPbYZYb3LejY67sEg33ojkBM60-wnhGPvubAojnuQf7fbNfn1LVN5QuqKhXUr1CLyXUquqGOf4A7HNvYtNzWsSD_sDyGH6fB0rH-R4jSehmaEGCts8SrA9JXZb2dL949O_jgf8TnK0vo2hrI8vxCKvkX8T8_2iXapmAKHeB_l2dBG8ID_HyQjE1mFYSRskEWmRfhDBhLNWOtEkaI/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FArjtdkJA8k5Slg7NVxEJhrVzN_Sc70aKks5vLxIjgaJpZM4ZHeGb.

whittsxnbq commented 5 years ago

More specifically, I’m reviewing the Word version of the documentation called WERB-final dated Feb 1 2019. If you go to page 102, it lists the Election Type enumeration and the definitions in that chart are still the old ones.

From: Whitt, Sarah - ELECTIONS Sent: Wednesday, February 13, 2019 2:01 PM To: usnistgov/ElectionResultsReporting reply@reply.github.com; usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

HI, I just looked in github, and the word version of the schema documentation still has the wrong definitions. Can you send me a link to the version on github that has the correct ones? I need to send the documentation to some people but I want to send them the correct stuff.

From: John P. Wack notifications@github.com<mailto:notifications@github.com> Sent: Saturday, February 09, 2019 12:24 PM To: usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com<mailto:ElectionResultsReporting@noreply.github.com> Cc: Whitt, Sarah - ELECTIONS Sarah.Whitt@wisconsin.gov<mailto:Sarah.Whitt@wisconsin.gov>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

I've synced up definitions in 1500-100 V2 with those in the glossary; the most recent version of the spec (2019-02-01) matches up.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/1Xj5JnJRNSAvHQ6n_H-mm-BbKBnx2Aq9uEbiI8vvcMCQeoiWIriZH8R887fNt9UslwJ43aPzt2_JfimGQop7dK_ynHXv8bsAoZuzsKy7Xg5Q_ImAHhSenNNEMz_fajiXBgh7ejMIz2P8a8U2wVMbFUcBn-za6lJ4x7BSDavy7C12iYmgBp08RxMYksBICfRQY8M3yPusF8ZOZVzZP13-L4eRfPT3UJ86bOJlCiIGDsPygXjt9q5hv_rY4Ku-NMT8h/https%3A%2F%2Fgithub.com%2Fusnistgov%2FElectionResultsReporting%2Fissues%2F25%23issuecomment-462067303, or mute the threadhttps://secure-web.cisco.com/1eLyr0TbsqHTfrVmlHuslPFTD_toMhOf80Dguep0MrmrGL3l6hPbYZYb3LejY67sEg33ojkBM60-wnhGPvubAojnuQf7fbNfn1LVN5QuqKhXUr1CLyXUquqGOf4A7HNvYtNzWsSD_sDyGH6fB0rH-R4jSehmaEGCts8SrA9JXZb2dL949O_jgf8TnK0vo2hrI8vxCKvkX8T8_2iXapmAKHeB_l2dBG8ID_HyQjE1mFYSRskEWmRfhDBhLNWOtEkaI/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FArjtdkJA8k5Slg7NVxEJhrVzN_Sc70aKks5vLxIjgaJpZM4ZHeGb.

johnpwack commented 5 years ago

I hope the latest version I uploaded does the trick. I synced the glossary terms with those in John's living version fo the glossary. This version also has a few small changes suggested by Jennifer Morrell.

whittsxnbq commented 5 years ago

The Word doc for WERB-Final for 2019-02-09 is still wrong on page 102.

From: John P. Wack notifications@github.com Sent: Friday, February 15, 2019 9:52 AM To: usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com Cc: Whitt, Sarah - ELECTIONS Sarah.Whitt@wisconsin.gov; Author author@noreply.github.com Subject: Re: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

I hope the latest version I uploaded does the trick. I synced the glossary terms with those in John's living version fo the glossary. This version also has a few small changes suggested by Jennifer Morrell.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/16Z-qvsw5YmjCffcMVd_A1f9bOlWTQuA8aJgSObvBF0t8BWChacWi-zsLisc2CpuWYfhDRT_7Xkp3bwiJugx_iCVHxXD77TKOwyVUDD008CglKqT3SSDNX-sJEA5tBEbSXPgKXa2MtjmVZSAE7poqjU0td79AEpXbx_dJ1wQGr1cmJ1Rtl4YyskeDF2IKut_zsOH2Jl1AyguNrd8AYPg5keVl5NY_aEnrPjM2fu9o7Zdj_3dwPsMQlzfwlGxsUCoA/https%3A%2F%2Fgithub.com%2Fusnistgov%2FElectionResultsReporting%2Fissues%2F25%23issuecomment-464099000, or mute the threadhttps://secure-web.cisco.com/1BgShn7WVoEKvzmB4OnuQUMdMnF1r1XhvMgffkIJFYXL40PqpCNIVAG1x7JdveXiyvuSUBWjkx5a_VFPEZdeQj5_V24bs4R7gaFQp6Ud9rEUEnXs4O8wvsLmxnrIaM3Dcq4CaVZBlREYHDQh_Zo5Da0V3k2uGhRtjPOA-0qq0QWNc3i_iJvH39hzN9DARzX0E5-QoJc80wp8Vddp2VCcEhqZpE16f8e8X834sBdfoPyIgJiNuUpb8px4gBfArf1tF/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FArjtdlZNuLl1Y24AXZ1P7oiGwsPvKtTWks5vNteqgaJpZM4ZHeGb.

JDziurlaj commented 5 years ago

Hi John,

I think Sarah is referring to the enumeration ElectionType in the UML Documentation.

whittsxnbq commented 5 years ago

I verified that in the Living Glossary on Github has definition for General Election as “Election in which all eligible voters, regardless of party affiliation, are permitted to select candidates to fill public office and/or vote on ballot measures.”

In the WERB-Final version on page 102 where it lists the Election Type enumeration, the definition for General Election says “For the election held typically on the national day for elections (e.g., the Tuesday after the 1st Monday in November).”

Please make the Election Type enumeration definitions match the Living Glossary definitions.

From: Whitt, Sarah - ELECTIONS Sent: Friday, February 15, 2019 1:20 PM To: 'usnistgov/ElectionResultsReporting' reply@reply.github.com; usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com Cc: Author author@noreply.github.com Subject: RE: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

The Word doc for WERB-Final for 2019-02-09 is still wrong on page 102.

From: John P. Wack notifications@github.com<mailto:notifications@github.com> Sent: Friday, February 15, 2019 9:52 AM To: usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com<mailto:ElectionResultsReporting@noreply.github.com> Cc: Whitt, Sarah - ELECTIONS Sarah.Whitt@wisconsin.gov<mailto:Sarah.Whitt@wisconsin.gov>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

I hope the latest version I uploaded does the trick. I synced the glossary terms with those in John's living version fo the glossary. This version also has a few small changes suggested by Jennifer Morrell.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/16Z-qvsw5YmjCffcMVd_A1f9bOlWTQuA8aJgSObvBF0t8BWChacWi-zsLisc2CpuWYfhDRT_7Xkp3bwiJugx_iCVHxXD77TKOwyVUDD008CglKqT3SSDNX-sJEA5tBEbSXPgKXa2MtjmVZSAE7poqjU0td79AEpXbx_dJ1wQGr1cmJ1Rtl4YyskeDF2IKut_zsOH2Jl1AyguNrd8AYPg5keVl5NY_aEnrPjM2fu9o7Zdj_3dwPsMQlzfwlGxsUCoA/https%3A%2F%2Fgithub.com%2Fusnistgov%2FElectionResultsReporting%2Fissues%2F25%23issuecomment-464099000, or mute the threadhttps://secure-web.cisco.com/1BgShn7WVoEKvzmB4OnuQUMdMnF1r1XhvMgffkIJFYXL40PqpCNIVAG1x7JdveXiyvuSUBWjkx5a_VFPEZdeQj5_V24bs4R7gaFQp6Ud9rEUEnXs4O8wvsLmxnrIaM3Dcq4CaVZBlREYHDQh_Zo5Da0V3k2uGhRtjPOA-0qq0QWNc3i_iJvH39hzN9DARzX0E5-QoJc80wp8Vddp2VCcEhqZpE16f8e8X834sBdfoPyIgJiNuUpb8px4gBfArf1tF/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FArjtdlZNuLl1Y24AXZ1P7oiGwsPvKtTWks5vNteqgaJpZM4ZHeGb.

johnpwack commented 5 years ago

Ok, I missed that it was in the enumeration definition, it is fixed now. Probably those enumeration values should not be documented as they are; they should point to the glossary definitions.

whittsxnbq commented 5 years ago

I have found it very handy to have the definitions within the enumerations. However I can also see why that would be difficult to synch. I would recommend that someone check all the enumeration definitions to confirm they match the glossary. Or else remove them all?

From: John P. Wack notifications@github.com Sent: Tuesday, February 19, 2019 7:35 AM To: usnistgov/ElectionResultsReporting ElectionResultsReporting@noreply.github.com Cc: Whitt, Sarah - ELECTIONS Sarah.Whitt@wisconsin.gov; Author author@noreply.github.com Subject: Re: [usnistgov/ElectionResultsReporting] Election Type enumerations and definitions do not match VVSG glossary (#25)

Ok, I missed that it was in the enumeration definition, it is fixed now. Probably those enumeration values should not be documented as they are; they should point to the glossary definitions.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://secure-web.cisco.com/1qB-8BwU6aJSan6Gu-8PqBbjawYxlttUTCjTNmL_MMa9rvGwRJYFuG9eVcwgK5ZZ77rA5zkkJFqN-gDTXRQinNQzJZDA8Tz8vJQBhPQ76MGrkaSLKD3u2gznvtaX28PuwsuG-T4aHZ7Ej-DIfGaqky7Ih2ZQzZ85pEdV2LTM6JnduF6N8IV1ugPEufqw2J199cQkE8KXBKITF48A8_PEdh-qpTc8psSX2DiCQHqKifAz88sM5Jt6Gk1PQjyuq5Ci6/https%3A%2F%2Fgithub.com%2Fusnistgov%2FElectionResultsReporting%2Fissues%2F25%23issuecomment-465129835, or mute the threadhttps://secure-web.cisco.com/1tSoiGUK6TlvjWlL2IYZSTpGyslQF_y2ccDcT_CVWSy7bopDh83Nlypv1OjUGDHZVo0Cyo5TvzU0XGxpYMbXAPuNakjK2tOb8KcSlYlNoQ5Un0-ai79ihQfrAqCzY9ch0ShxlmB5CoFDC5aVJUhsWaT-0nvmJDPmZzWF1f9F2S8H5OP-6GheJoCfilSBJcz59Op-g9JrApoAUNdK6oH_XuxWxEcp6hqbbdmldhwJCWGgfwK5CUF_4-bnAmPDnxAtt/https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FArjtdiq4wvkRM1zZzmxcVDRuEHDvC3CHks5vO_2UgaJpZM4ZHeGb.

whittsxnbq commented 4 years ago

The enumeration definitions I mentioned are now fixed so I am closing this out.