usnistgov / ElectionResultsReporting

Common data format specification for election results reporting data
https://pages.nist.gov/ElectionResultsReporting
Other
23 stars 8 forks source link

Discrepancy between Election Results Common Data Format Specification Revision 2.0 and ElectionResultsReportingV2.png #51

Open sfsinger19103 opened 4 years ago

sfsinger19103 commented 4 years ago

According to the pdf document Election Results Common Data Format Specification Revision 2.0:

Election and Contest contain a required reference to GpUnit representing the jurisdiction of the election or contest respectively; Office contains a similar reference that is optional.

In the diagram of the CDF, Election and Contest contain a required reference to ReportingUnit, not GpUnit.

If the diagram were corrected to match the pdf document, some of my pain from #42 would be alleviated!

sfsinger19103 commented 4 years ago

For my use case, if the above change were made, it would be even better to take out the sub-class relationship between GpUnit and ReportingUnit, and replace it with a required reference. In other words, replace the Generalization arrowhead with a Directed Association arrowhead, with multiplicity 1.

sfsinger19103 commented 4 years ago

If the changes above were made, one might also considering moving some elements of the current ReportingUnitType enumeration (e.g., 'congressional') to a new GpUnitType enumeration.