search

usnistgov / NEMO

NEMO is a laboratory logistics web application. Use it to schedule reservations, control tool access, track maintenance issues, and more.
Other
135 stars 63 forks source link

Page title customizations #181

Closed abuckles-uci closed 10 months ago

abuckles-uci commented 10 months ago

This resolves #174. It allows for the "Calendar", "Tool control", "Status dashboard", "Requests", and "Safety" navbar links display text to be customized.

Is the way I saved the customizations correct? It works locally for me. Also, is the organization of the customizations acceptable?

image

rptmat57 commented 10 months ago

Hi, I would prefer to have all the navbar customizations in the "Application" customization. Maybe in a "Navbar" subsection (separated by a line in the page)?

rptmat57 commented 10 months ago

I would also look in each template file, for example in status_dashboard.html and change the name in the title block and in the <h1> element

rptmat57 commented 10 months ago

other than that it looks great, thank you for working on this!

abuckles-uci commented 10 months ago

oh and one last thing, if you could rename all the navbar settings to navbar_* that'd be great, i.e. navbar_calendar_text, navbar_tool_control_text etc. this way it will be consistent with the navbar subsection name

Oops just saw this. I renamed them to *_page_title since it includes more than just navbar changes. Let me know what you think. I can make it page_title_* instead if you think that's better.

abuckles-uci commented 10 months ago

Now on the "Application" tab

image

rptmat57 commented 10 months ago

I just deleted my comment, I like what you did. I am going to do one last code review tonight but this looks great! Thank you!!

abuckles-uci commented 10 months ago

I just deleted my comment, I like what you did. I am going to do one last code review tonight but this looks great! Thank you!!

Ok cool, thanks!