usnistgov / NFIQ2

Optical live-scan and ink fingerprint image quality assessment tool
https://www.nist.gov/services-resources/software/development-nfiq-20
Other
129 stars 57 forks source link

Image dimension checking is off-by-one #297

Closed gfiumara closed 3 years ago

gfiumara commented 3 years ago

https://github.com/usnistgov/NFIQ2/blob/e20b898ab5d83e1865deeeca3098fbe469c444ec/NFIQ2/NFIQ2Algorithm/src/nfiq2/nfiq2_fingerprintimagedata.cpp#L162

In FingerJet, the dimension bounds checking happens with asserts that are logically opposite of what we check. For instance, this line in FingerJet should be the opposite check of this line in NFIQ 2. Thus, NFIQ 2 should be checking if the width is < the min, not <=, and > the max, not >=.

(Submitted on behalf of the MITRE MTF and IQS Assessment team.)